[lkml]   [2016]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] usb: ehci-platform: use helper variables in probe function
On Wed, 13 Jul 2016, Rafał Miłecki wrote:

> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
> Signed-off-by: Rafał Miłecki <>

Okay except for...

> - priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
> - "phys", "#phy-cells");
> + priv->num_phys = of_count_phandle_with_args(np, "phys",
> + "#phy-cells");

Please indent continuation lines two tab stops beyond the original
line, to match the style in the rest of the source file.

With that change,

Acked-by: Alan Stern <>

Alan Stern

 \ /
  Last update: 2016-07-14 17:01    [W:0.099 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site