Messages in this thread |  | | Date | Thu, 14 Jul 2016 14:59:49 +0200 | From | Ingo Molnar <> | Subject | Re: [patch 1/2] drivers/virt: fix the error handling in ioctl_dtprop() |
| |
* Dan Carpenter <dan.carpenter@oracle.com> wrote:
> If strndup_user() user fails then it returns an error pointer and we > pass that to kfree() which causes an oops.
Hm, in addition to this fix wouldn't it be better to not crash if kfree() gets passed an error pointer? Would that have changed the pattern of this particular bug?
Thanks,
Ingo
|  |