Messages in this thread |  | | From | "Yu, Fenghua" <> | Subject | RE: [PATCH 30/32] x86/intel_rdt_rdtgroup.c: Process schemas input from rscctrl interface | Date | Thu, 14 Jul 2016 06:16:15 +0000 |
| |
> From: Thomas Gleixner [mailto:tglx@linutronix.de] > Sent: Wednesday, July 13, 2016 11:11 PM > On Wed, 13 Jul 2016, David Carrillo-Cisneros wrote: > > > +static void free_cache_resource(struct cache_resource *l) { > > > + kfree(l->cbm); > > > + kfree(l->cbm2); > > > + kfree(l->closid); > > > + kfree(l->refcnt); > > > > this function is used to clean up alloc_cache_resource in the error > > path of get_resources where it's not necessarily true that all of l's > > members were allocated. > > kfree handles kfree(NULL) nicely.....
Yes, that's right. If I check the pointer before kfree(), checkpatch.pl will report warning for that and suggest kfree(NULL) is safe and code is short.
Thanks.
-Fenghua
|  |