Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 3.12 73/88] ALSA: timer: Fix leak in events via snd_timer_user_ccallback | Date | Thu, 14 Jul 2016 10:16:05 +0200 |
| |
From: Kangjie Lu <kangjielu@gmail.com>
3.12-stable review patch. If anyone has any objections, please let me know.
===============
commit 9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6 upstream.
The stack object “r1” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- sound/core/timer.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/core/timer.c b/sound/core/timer.c index 7bf8186472fb..aa0582c5dd2e 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -1218,6 +1218,7 @@ static void snd_timer_user_ccallback(struct snd_timer_instance *timeri, tu->tstamp = *tstamp; if ((tu->filter & (1 << event)) == 0 || !tu->tread) return; + memset(&r1, 0, sizeof(r1)); r1.event = event; r1.tstamp = *tstamp; r1.val = resolution; -- 2.9.1
| |