| From | Jiri Slaby <> | Subject | [PATCH 3.12 72/88] ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS | Date | Thu, 14 Jul 2016 10:16:04 +0200 |
| |
From: Kangjie Lu <kangjielu@gmail.com>
3.12-stable review patch. If anyone has any objections, please let me know.
===============
commit cec8f96e49d9be372fdb0c3836dcf31ec71e457e upstream.
The stack object “tread” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- sound/core/timer.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/core/timer.c b/sound/core/timer.c index 10463beae4bb..7bf8186472fb 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -1717,6 +1717,7 @@ static int snd_timer_user_params(struct file *file, if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) { if (tu->tread) { struct snd_timer_tread tread; + memset(&tread, 0, sizeof(tread)); tread.event = SNDRV_TIMER_EVENT_EARLY; tread.tstamp.tv_sec = 0; tread.tstamp.tv_nsec = 0; -- 2.9.1
|