lkml.org 
[lkml]   [2016]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n
Date
On Thursday, July 14, 2016 8:21:11 AM CEST Jiri Pirko wrote:
> >diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h
> >index 333c32ac9bfa..26f92d3c7e9c 100644
> >--- a/include/trace/events/devlink.h
> >+++ b/include/trace/events/devlink.h
> >@@ -22,7 +22,11 @@ TRACE_EVENT(devlink_hwmsg,
> > TP_STRUCT__entry(
> > __string(bus_name, devlink->dev->bus->name)
> > __string(dev_name, dev_name(devlink->dev))
> >+#ifdef CONFIG_MODULES
> > __string(owner_name, devlink->dev->driver->owner->name)
>
> I think would be better to use driver->name. I looks like it is always
> present. I will do some tests and send a patch.
>

Yes, good idea.

Arnd

\
 
 \ /
  Last update: 2016-07-14 11:01    [W:0.042 / U:31.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site