lkml.org 
[lkml]   [2016]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable
On Tue, 12 Jul 2016, Cong Wang wrote:

> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index f45929c..0b5c172e 100644
> > --- a/include/linux/netdevice.h
> > +++ b/include/linux/netdevice.h
> > @@ -52,6 +52,7 @@
> > #include <uapi/linux/netdevice.h>
> > #include <uapi/linux/if_bonding.h>
> > #include <uapi/linux/pkt_cls.h>
> > +#include <linux/hashtable.h>
> >
> > struct netpoll_info;
> > struct device;
> > @@ -1778,6 +1779,7 @@ struct net_device {
> > unsigned int num_tx_queues;
> > unsigned int real_num_tx_queues;
> > struct Qdisc *qdisc;
> > + DECLARE_HASHTABLE (qdisc_hash, 4);
> > unsigned long tx_queue_len;
> > spinlock_t tx_global_lock;
> > int watchdog_timeo;
>
> Should it be surrounded by CONFIG_NET_SCHED?
> To save several bytes for !CONFIG_NET_SCHED case.

Makes sense. I'll wait a bit for more feedback (if there is any) before
including this in potential v4.

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2016-07-13 16:21    [W:0.967 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site