Messages in this thread | | | Subject | Re: [PATCH v6 17/46] infiniband: dma-mapping: Use unsigned long for dma_attrs | From | Krzysztof Kozlowski <> | Date | Wed, 13 Jul 2016 13:03:36 +0200 |
| |
On 07/13/2016 12:56 PM, Bart Van Assche wrote: > On 07/13/2016 05:47 PM, Krzysztof Kozlowski wrote: >> On 07/13/2016 12:37 PM, Bart Van Assche wrote: >>> On 07/13/2016 03:41 PM, Krzysztof Kozlowski wrote: >>>> Split out subsystem specific changes for easier reviews. This will be >>>> squashed with main commit. >>> >>> Apparently my comment has been ignored >>> (http://thread.gmane.org/gmane.linux.ports.m68k/8746/focus=37703). Are >>> you aware that you are expected to reply to feedback on patches? >> >> Of course your comment was not ignored. I am sorry that you have such >> impression. However I thought you are referring only to local variable >> which name I changed. >> >> Do you want me to rename also the argument in the ib_dma_map_sg_attrs() >> and ib_dma_unmap_sg_attrs() functions? > > Hello Krzysztof, > > Sorry if I was not clear enough in the comment I had posted in reply to > the previous version of this patch series. In my comment I wanted indeed > to refer to the name of the ib_dma_map_sg_attrs() / > ib_dma_unmap_sg_attrs() function argument. An argument with the name > "attrs" namely does not explain what kind of attributes that argument > refers to ...
I can rename it, no problem. It looks to me a little bit redundant information as these are just wrappers over dma_{map,unmap}_sg_attrs() where the attrs are also used. Everything there refers to the mapping of scatter gather list. Anyway, renaming won't harm neither so let me send a follow up only for this patch.
Thanks for feedback! Krzysztof
| |