Messages in this thread | | | Subject | Re: [PATCH 6/8] x86: xen: audit and remove any unnecessary uses of module.h | From | Juergen Gross <> | Date | Thu, 14 Jul 2016 05:59:10 +0200 |
| |
On 14/07/16 02:18, Paul Gortmaker wrote: > Historically a lot of these existed because we did not have > a distinction between what was modular code and what was providing > support to modules via EXPORT_SYMBOL and friends. That changed > when we forked out support for the latter into the export.h file. > > This means we should be able to reduce the usage of module.h > in code that is obj-y Makefile or bool Kconfig. The advantage > in doing so is that module.h itself sources about 15 other headers; > adding significantly to what we feed cpp, and it can obscure what > headers we are effectively using. > > Since module.h was the source for init.h (for __init) and for > export.h (for EXPORT_SYMBOL) we consider each obj-y/bool instance > for the presence of either and replace as needed. > > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: David Vrabel <david.vrabel@citrix.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: x86@kernel.org > Cc: xen-devel@lists.xenproject.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Juergen Gross <jgross@suse.com>
Juergen
| |