lkml.org 
[lkml]   [2016]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] GPU-DRM-Radeon: Delete an unnecessary check before drm_gem_object_unreference_unlocked()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 12 Jul 2016 22:00:55 +0200

    The drm_gem_object_unreference_unlocked() function tests whether
    its argument is NULL and then returns immediately.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/radeon/radeon_display.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
    index 5f1cd69..1efab5f 100644
    --- a/drivers/gpu/drm/radeon/radeon_display.c
    +++ b/drivers/gpu/drm/radeon/radeon_display.c
    @@ -1324,9 +1324,7 @@ static void radeon_user_framebuffer_destroy(struct drm_framebuffer *fb)
    {
    struct radeon_framebuffer *radeon_fb = to_radeon_framebuffer(fb);

    - if (radeon_fb->obj) {
    - drm_gem_object_unreference_unlocked(radeon_fb->obj);
    - }
    + drm_gem_object_unreference_unlocked(radeon_fb->obj);
    drm_framebuffer_cleanup(fb);
    kfree(radeon_fb);
    }
    --
    2.9.0
    \
     
     \ /
      Last update: 2016-07-12 23:01    [W:4.023 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site