Messages in this thread | | | Subject | Re: [PATCH v3 2/2] Bindings documentation for ISSI is31fl319x driver | From | Jacek Anaszewski <> | Date | Tue, 12 Jul 2016 22:14:46 +0200 |
| |
Hi Nikolaus,
On 07/08/2016 09:49 PM, H. Nikolaus Schaller wrote: > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > .../devicetree/bindings/leds/is31fl319x.txt | 52 ++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt > > diff --git a/Documentation/devicetree/bindings/leds/is31fl319x.txt b/Documentation/devicetree/bindings/leds/is31fl319x.txt > new file mode 100644 > index 0000000..065e78c > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/is31fl319x.txt > @@ -0,0 +1,52 @@ > +LEDs connected to is31fl319x LED controller chip > + > +Required properties: > +- compatible : Should be any of > + "issi,is31fl3190" > + "issi,is31fl3191" > + "issi,is31fl3193" > + "issi,is31fl3196" > + "issi,is31fl3199" > + "si-en,sn3199". > +- #address-cells: Must be 1. > +- #size-cells: Must be 0. > +- reg: 0x64, 0x65, 0x66, 0x67. > + > +Optional properties: > +- led-max-microamp : See Documentation/devicetree/bindings/leds/common.txt. > + Valid values: 5000 - 40000, step by 5000 (rounded down) > + Default: 20000 (20 mA) > +- audio-gain-db : audio gain selection for external analog modulation input. > + Valid values: 0 - 21, step by 3 (rounded down) > + Default: 0 > + > +Each led is represented as a sub-node of the issi,is31fl319x device. > +There can be less leds subnodes than the chip can support but not more. > + > +LED sub-node properties: > +- label : (optional) see Documentation/devicetree/bindings/leds/common.txt. > +- reg : number of LED line > + Valid values: 1 - number of leds supported by the chip variant. > +- linux,default-trigger : (optional) > + see Documentation/devicetree/bindings/leds/common.txt. > + > +Examples: > + > +fancy_leds: leds@65 { > + compatible = "issi,is31fl3196"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x65>; > + > + red_aux: led@1 { > + label = "red:aux"; > + reg = <1>; > + }; > + > + green_power: led@5 { > + label = "green:power"; > + reg = <5>; > + linux,default-trigger = "default-on"; > + }; > +}; > +
You have an extra empty line at the end.
-- Best regards, Jacek Anaszewski
| |