Messages in this thread Patch in this message | | | Date | Tue, 12 Jul 2016 08:40:01 -0700 | From | tip-bot for Anna-Maria Gleixner <> | Subject | [tip:timers/core] clocksource/drivers/time-armada-370-xp: Fix return value check |
| |
Commit-ID: 1d661bf5327a2c059ec967f850e89362e637f4e6 Gitweb: http://git.kernel.org/tip/1d661bf5327a2c059ec967f850e89362e637f4e6 Author: Anna-Maria Gleixner <anna-maria@linutronix.de> AuthorDate: Tue, 12 Jul 2016 16:40:09 +0200 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Tue, 12 Jul 2016 17:33:22 +0200
clocksource/drivers/time-armada-370-xp: Fix return value check
The failure check of armada_370_xp_timer_setup() in armada_370_xp_timer_common_init() is negated. This leads to an error message and exit in case of a successful initialization. Remove the stray '!'.
Fixes: 12549e27c63c ("clocksource/drivers/time-armada-370-xp: Convert init function to return error") Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Link: http://lkml.kernel.org/r/alpine.DEB.2.11.1607121731020.1344@hypnos.tec.linutronix.de Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
--- drivers/clocksource/time-armada-370-xp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c index a4e5923..20ec066 100644 --- a/drivers/clocksource/time-armada-370-xp.c +++ b/drivers/clocksource/time-armada-370-xp.c @@ -342,7 +342,7 @@ static int __init armada_370_xp_timer_common_init(struct device_node *np) } res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt)); - if (!res) { + if (res) { pr_err("Failed to setup timer"); return res; }
| |