lkml.org 
[lkml]   [2016]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/34] mm, vmscan: remove duplicate logic clearing node congestion and dirty state
On Fri, Jul 08, 2016 at 10:34:47AM +0100, Mel Gorman wrote:
> @@ -3008,7 +3008,17 @@ static bool zone_balanced(struct zone *zone, int order, int classzone_idx)
> {
> unsigned long mark = high_wmark_pages(zone);
>
> - return zone_watermark_ok_safe(zone, order, mark, classzone_idx);
> + if (!zone_watermark_ok_safe(zone, order, mark, classzone_idx))
> + return false;
> +
> + /*
> + * If any eligible zone is balanced then the node is not considered
> + * to be congested or dirty
> + */
> + clear_bit(PGDAT_CONGESTED, &zone->zone_pgdat->flags);
> + clear_bit(PGDAT_DIRTY, &zone->zone_pgdat->flags);

Predicate functions that secretly modify internal state give me the
willies... The diffstat is flat, too. Is this really an improvement?

\
 
 \ /
  Last update: 2016-07-12 16:41    [W:0.415 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site