lkml.org 
[lkml]   [2016]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 02/66] irqchip/gic: Convert to hotplug state machine
On Mon, 11 Jul 2016, Ingo Molnar wrote:

>
> * Anna-Maria Gleixner <anna-maria@linutronix.de> wrote:
>
> > More or less straightforward, although this driver sports some very
> > interesting SMP setup code. Regarding the callback ordering, this
> > deleted comment is interesting:
> >
> > ... the GIC needs to be up before the ARM generic timers.
> >
> > That comment is half baken as the same requirement is true for perf.
> >
> > Signed-off-by: Richard Cochran <rcochran@linutronix.de>
> > Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > Cc: Jason Cooper <jason@lakedaemon.net>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
>
> The SOB sequence is unusal. Is this patch missing this line:
>
> From: Richard Cochran <rcochran@linutronix.de>
>

This line is missing.

Thanks,
Anna-Maria

\
 
 \ /
  Last update: 2016-07-11 17:21    [W:0.075 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site