[lkml]   [2016]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Missing include file in include/uapi/linux/errqueue.h?
On Sun, Jul 10, 2016 at 1:43 AM, Brooks Moses <> wrote:
> On Sat, Jul 9, 2016 at 10:36 AM, Brooks Moses <> wrote:
>> I've been attempting to qualify the Linux 4.5.2 user-space headers for
>> a toolchain release, and ran into what looks like a missing include
>> file in include/uapi/linux/errqueue.h. In particular,
>> adds the following to this file:
>> +struct scm_timestamping {
>> + struct timespec ts[3];
>> +};
>> However, struct timespec is defined in time.h, which isn't included
>> either in 4.5.2 or in current head. Is this simply a missing #include
>> line,

It is. I missed that in my original patch.

> or am I misunderstanding something?
> As a followup: Unfortunately the obvious fix -- adding "#include
> <linux/time.h>" -- causes other problems, since linux/time.h is
> incompatible with the glibc time.h such that including both of them
> into the same compilation unit causes errors about redefined types.

If these conflicts between libc and uapi time.h can be resolved through
include/uapi/linux/libc-compat.h, then we can apply the obvious fix of
including linux/time.h in linux/errqueue.h.

> And we, at least, have some programs that want to include
> linux/errqueue.h and (glibc's) time.h. The fix of adding "#include
> <time.h>" to linux/errqueue.h seems to work for us, but I'm not sure
> that won't cause problems in the other direction for other people.

That breaks kernel compilation.

 \ /
  Last update: 2016-07-10 16:41    [W:0.051 / U:4.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site