Messages in this thread | | | From | Joonsoo Kim <> | Date | Fri, 1 Jul 2016 23:03:13 +0900 | Subject | Re: [PATCH v2] kasan/quarantine: fix bugs on qlist_move_cache() |
| |
2016-07-01 22:55 GMT+09:00 <js1304@gmail.com>: > From: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > There are two bugs on qlist_move_cache(). One is that qlist's tail > isn't set properly. curr->next can be NULL since it is singly linked > list and NULL value on tail is invalid if there is one item on qlist. > Another one is that if cache is matched, qlist_put() is called and > it will set curr->next to NULL. It would cause to stop the loop > prematurely. > > These problems come from complicated implementation so I'd like to > re-implement it completely. Implementation in this patch is really > simple. Iterate all qlist_nodes and put them to appropriate list. > > Unfortunately, I got this bug sometime ago and lose oops message. > But, the bug looks trivial and no need to attach oops. > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Please ignore this. It causes build warning. Please see v3. Sorry for noise.
Thanks.
| |