lkml.org 
[lkml]   [2016]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 06/15] [media] lirc_dev: do not use goto to create loops
    Date
    ... use "do .. while" instead.

    Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
    ---
    drivers/media/rc/lirc_dev.c | 10 ++++------
    1 file changed, 4 insertions(+), 6 deletions(-)

    diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
    index 0d988c9..da1777c 100644
    --- a/drivers/media/rc/lirc_dev.c
    +++ b/drivers/media/rc/lirc_dev.c
    @@ -99,18 +99,16 @@ static int lirc_add_to_buf(struct irctl *ir)
    {
    if (ir->d.add_to_buf) {
    int res = -ENODATA;
    - int got_data = 0;
    + int got_data = -1;

    /*
    * service the device as long as it is returning
    * data and we have space
    */
    -get_data:
    - res = ir->d.add_to_buf(ir->d.data, ir->buf);
    - if (res == 0) {
    + do {
    got_data++;
    - goto get_data;
    - }
    + res = ir->d.add_to_buf(ir->d.data, ir->buf);
    + } while (!res);

    if (res == -ENODEV)
    kthread_stop(ir->task);
    --
    2.8.1
    \
     
     \ /
      Last update: 2016-07-01 11:01    [W:4.034 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site