Messages in this thread | | | From | Deepa Dinamani <> | Date | Thu, 9 Jun 2016 17:53:10 -0700 | Subject | Re: [PATCH 06/21] fs: udf: Replace CURRENT_TIME with current_fs_time() |
| |
On Thu, Jun 9, 2016 at 12:41 AM, Jan Kara <jack@suse.cz> wrote: > On Wed 08-06-16 22:04:50, Deepa Dinamani wrote: >> Logical Volume Integrity format is described to have the >> same timestamp format for "Recording Date and time" as >> the other [a,c,m]timestamps. >> Hence using current_fs_time() instead here promises to >> maintain the same granularity as other timestamps. >> > Just one nit below. > >> @@ -2030,7 +2030,7 @@ static void udf_close_lvid(struct super_block *sb) >> - udf_time_to_disk_stamp(&lvid->recordingDateAndTime, CURRENT_TIME); >> + udf_time_to_disk_stamp(&lvid->recordingDateAndTime, current_fs_time(sb)); > > Please wrap this line properly so that it does not exceed 80 characters. > Other than that feel free to add: > > Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, I will take care of this in v2 of the patch series. - Deepa
| |