lkml.org 
[lkml]   [2016]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 009/206] xfs: Don't wrap growfs AGFL indexes
    Date
    4.2.8-ckt12 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Dave Chinner <dchinner@redhat.com>

    commit ad747e3b299671e1a53db74963cc6c5f6cdb9f6d upstream.

    Commit 96f859d ("libxfs: pack the agfl header structure so
    XFS_AGFL_SIZE is correct") allowed the freelist to use the empty
    slot at the end of the freelist on 64 bit systems that was not
    being used due to sizeof() rounding up the structure size.

    This has caused versions of xfs_repair prior to 4.5.0 (which also
    has the fix) to report this as a corruption once the filesystem has
    been grown. Older kernels can also have problems (seen from a whacky
    container/vm management environment) mounting filesystems grown on a
    system with a newer kernel than the vm/container it is deployed on.

    To avoid this problem, change the initial free list indexes not to
    wrap across the end of the AGFL, hence avoiding the initialisation
    of agf_fllast to the last index in the AGFL.

    Signed-off-by: Dave Chinner <dchinner@redhat.com>
    Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
    Signed-off-by: Dave Chinner <david@fromorbit.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    fs/xfs/xfs_fsops.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
    index 9b3438a..df4bc93 100644
    --- a/fs/xfs/xfs_fsops.c
    +++ b/fs/xfs/xfs_fsops.c
    @@ -243,8 +243,8 @@ xfs_growfs_data_private(
    agf->agf_roots[XFS_BTNUM_CNTi] = cpu_to_be32(XFS_CNT_BLOCK(mp));
    agf->agf_levels[XFS_BTNUM_BNOi] = cpu_to_be32(1);
    agf->agf_levels[XFS_BTNUM_CNTi] = cpu_to_be32(1);
    - agf->agf_flfirst = 0;
    - agf->agf_fllast = cpu_to_be32(XFS_AGFL_SIZE(mp) - 1);
    + agf->agf_flfirst = cpu_to_be32(1);
    + agf->agf_fllast = 0;
    agf->agf_flcount = 0;
    tmpsize = agsize - XFS_PREALLOC_BLOCKS(mp);
    agf->agf_freeblks = cpu_to_be32(tmpsize);
    --
    2.7.4
    \
     
     \ /
      Last update: 2016-06-10 01:01    [W:4.433 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site