lkml.org 
[lkml]   [2016]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 024/206] ath10k: fix rx_channel during hw reconfigure
    Date
    4.2.8-ckt12 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>

    commit 1ce8c1484e80010a6e4b9611c65668ff77556f45 upstream.

    Upon firmware assert, restart work will be triggered so that mac80211
    will reconfigure the driver. An issue is reported that after restart
    work, survey dump data do not contain in-use (SURVEY_INFO_IN_USE) info
    for operating channel. During reconfigure, since mac80211 already has
    valid channel context for given radio, channel context iteration return
    num_chanctx > 0. Hence rx_channel is always NULL. Fix this by assigning
    channel context to rx_channel when driver restart is in progress.

    Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/net/wireless/ath/ath10k/mac.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
    index 9301716..fb84cf0 100644
    --- a/drivers/net/wireless/ath/ath10k/mac.c
    +++ b/drivers/net/wireless/ath/ath10k/mac.c
    @@ -6123,7 +6123,13 @@ ath10k_mac_update_rx_channel(struct ath10k *ar,
    def = &vifs[0].new_ctx->def;

    ar->rx_channel = def->chan;
    - } else if (ctx && ath10k_mac_num_chanctxs(ar) == 0) {
    + } else if ((ctx && ath10k_mac_num_chanctxs(ar) == 0) ||
    + (ctx && (ar->state == ATH10K_STATE_RESTARTED))) {
    + /* During driver restart due to firmware assert, since mac80211
    + * already has valid channel context for given radio, channel
    + * context iteration return num_chanctx > 0. So fix rx_channel
    + * when restart is in progress.
    + */
    ar->rx_channel = ctx->def.chan;
    } else {
    ar->rx_channel = NULL;
    --
    2.7.4
    \
     
     \ /
      Last update: 2016-06-10 01:01    [W:4.131 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site