[lkml]   [2016]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHv5 0/8] 2c: Relax mandatory I2C ID table passing
Hi Kieran,

> * Device Tree
> I tested that the device would still register by adding a node in the device
> tree for the board, and testing with a built-in module.
> - This worked fine.
> * Module Autoloading
> With the device tree node in the board dts file, it wouldn't automatically
> load from the external module. This was due to the rtc-ds1307 module not
> exporting an of_match table, and not yet having Javier's "report OF style
> modalias when probing using DT" [0] patch applied

What I didn't get here: did your version of the RTC driver use probe()
or probe_new() without i2c_device_id table or did you try both? I assume
module autoloading only fails with probe_new(), otherwise we would be in
serious trouble. But I'd wonder then that userspace instantiation works.

Thanks to you and Javier for the testing. I pushed the patches to a
local branch for now and will merge once this question is clear.



[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2016-06-09 22:01    [W:0.138 / U:2.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site