Messages in this thread | | | Date | Thu, 9 Jun 2016 10:29:57 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h |
| |
Em Wed, Jun 08, 2016 at 09:36:50PM +0900, Taeung Song escreveu: > Lately util/config.h has been added > but util/cache.h has declarations of functions > and extern variable for config features. > > To manage codes about configuration at one spot, move them > to util/config.h and util/cache.h include util/config.h > > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> > Cc: Jiri Olsa <jolsa@redhat.com> > Cc: Masami Hiramatsu <mhiramat@kernel.org> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Wang Nan <wangnan0@huawei.com> > Signed-off-by: Taeung Song <treeze.taeung@gmail.com> > --- > tools/perf/util/cache.h | 13 +------------ > tools/perf/util/config.h | 12 ++++++++++++ > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h > index 0d814bb..cd8cd4d 100644 > --- a/tools/perf/util/cache.h > +++ b/tools/perf/util/cache.h > @@ -7,6 +7,7 @@ > #include <subcmd/pager.h> > #include "../perf.h" > #include "../ui/ui.h" > +#include "config.h"
Why have you added that? Are those config functions used in cache.h?
- Arnaldo
| |