lkml.org 
[lkml]   [2016]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation
    On Wed, Jun 08, 2016 at 04:39:44PM +0900, Minchan Kim wrote:
    > On Mon, Jun 06, 2016 at 03:48:31PM -0400, Johannes Weiner wrote:
    > > @@ -832,9 +854,9 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
    > > * Add the passed pages to the LRU, then drop the caller's refcount
    > > * on them. Reinitialises the caller's pagevec.
    > > */
    > > -void __pagevec_lru_add(struct pagevec *pvec)
    > > +void __pagevec_lru_add(struct pagevec *pvec, bool new)
    > > {
    > > - pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, NULL);
    > > + pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, (void *)new);
    > > }
    >
    > Just trivial:
    >
    > 'new' argument would be not clear in this context what does it mean
    > so worth to comment it, IMO but no strong opinion.

    True, it's a little mysterious. I'll document it.

    > Other than that,
    >
    > Acked-by: Minchan Kim <minchan@kernel.org>

    Thanks!

    \
     
     \ /
      Last update: 2016-06-08 18:21    [W:4.636 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site