Messages in this thread | | | Date | Wed, 8 Jun 2016 07:43:16 -0700 (PDT) | From | Shrikrishna Khare <> | Subject | Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets |
| |
On Wed, 8 Jun 2016, Thomas Hellstrom wrote:
> > mss = rcdlro->mss; > > if (unlikely(segCnt <= 1)) > > segCnt = 0; > > Based on this code, it looks like it can handle the case without taking > down the kernel completely, so instead of a > "BUG_ON", would it make sense with a WARN_ON_ONCE() or WARN_ON()?
Thanks for the review Thomas. I fixed the code to use WARN_ON_ONCE. Sent out revised patch.
| |