lkml.org 
[lkml]   [2016]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 5/6] watchdog: pretimeout: add panic pretimeout governor
From
Date
Hi Wolfram,

On 08.06.2016 10:08, Wolfram Sang wrote:
>
>> +static void pretimeout_panic(struct watchdog_device *wdd)
>> +{
>> + panic("panic on watchdog pretimeout event\n");
>> +}
>
> And here we have the same redundant message again ("panic on") :(

I will remove it then.

> Did you look at my patches at all? To me, it looks like you didn't or
> you are intentionally trying to leave my changes out. I don't think they
> were all bad.

No, they are not, and I'll include some of the changes to v4, if you don't
mind.

> In the previous patch in watchdog_notify_pretimeout() you used
> the shortened message BTW.

--
With best wishes,
Vladimir

\
 
 \ /
  Last update: 2016-06-08 16:41    [W:0.100 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site