Messages in this thread | | | Date | Thu, 9 Jun 2016 02:17:39 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: stmmac: dwmac-rk: keep PHY up for WoL |
| |
On Wed, Jun 08, 2016 at 03:25:38PM -0700, Vincent Palatin wrote: > On Tue, Jun 7, 2016 at 12:23 AM, Giuseppe CAVALLARO > <peppe.cavallaro@st.com> wrote: > > Hello > > > > On 6/3/2016 7:29 PM, Vincent Palatin wrote: > >> > >> Do not shutdown the PHY if Wake-on-Lan is enabled, else it cannot wake > >> us up. > >> > > > > I do not understand why you need that. > > This is done inside the PHY layer and it is tested on our platforms > > he idea is: If the parent wants to Wake the system then the PHY should > > not power-down. > > I'm not sure I understand : > you mean that this path is not called if WoL is enabled ? > [ currently stmmac_pltfr_suspend() is calling priv->plat->exit() which > is the rk_gmac_exit() code I'm modifying ] > or the RK driver code should not power down the phy in its exit() callback ?
Take a look at phy_suspend().
Andrew
| |