lkml.org 
[lkml]   [2016]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: Regression in "kbuild: fix if_change and friends to consider argument order"
Date
Em Ter, 2016-06-07 às 23:52 +0200, Michal Marek escreveu:
> On Tue, Jun 07, 2016 at 02:10:28PM +0000, Zanoni, Paulo R wrote:
> > 
>
> From b36fad65d61fffe4b662d4bfb1ed673c455a36a2 Mon Sep 17 00:00:00
> 2001
> From: Michal Marek <mmarek@suse.com>
> Date: Tue, 7 Jun 2016 11:57:02 +0200
> Subject: [PATCH] kbuild: Initialize exported variables
>
> The NOSTDINC_FLAGS variable is exported, so it needs to be cleared to
> avoid duplicating its content when running make from within make
> (e.g.
> in the packaging targets). This became an issue after commit
> 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider argument
> order"), which no longer ignores the duplicate options. As Paulo
> Zanoni
> points out, the LDFLAGS_vmlinux variable has the same problem.
>
> Reported-by: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Fixes: 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider
> argument order")
> Signed-off-by: Michal Marek <mmarek@suse.com>

Works for me.

Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Thanks a lot!

> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 0f70de63cfdb..af0c463e908f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -363,11 +363,13 @@ CHECK = sparse
>  
>  CHECKFLAGS     := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
>     -Wbitwise -Wno-return-void $(CF)
> +NOSTDINC_FLAGS  =
>  CFLAGS_MODULE   =
>  AFLAGS_MODULE   =
>  LDFLAGS_MODULE  =
>  CFLAGS_KERNEL =
>  AFLAGS_KERNEL =
> +LDFLAGS_vmlinux =
>  CFLAGS_GCOV = -fprofile-arcs -ftest-coverage -fno-tree-loop-
> im -Wno-maybe-uninitialized
>  CFLAGS_KCOV = -fsanitize-coverage=trace-pc
>  
\
 
 \ /
  Last update: 2016-06-09 02:21    [W:0.086 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site