lkml.org 
[lkml]   [2016]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [tpmdd-devel] [PATCH v4 3/4] tpm: Allow TPM chip drivers to override reported command durations
On Wed, Jun 8, 2016 at 12:05 PM, Jason Gunthorpe
<jgunthorpe@obsidianresearch.com> wrote:
> On Tue, Jun 07, 2016 at 05:45:39PM -0700, Ed Swierk wrote:
>> + case 0x32041114: /* Atmel 3204 */
>> + chip->vendor.timeout_a = TIS_SHORT_TIMEOUT * HZ / 1000;
>> + chip->vendor.timeout_b = TIS_LONG_TIMEOUT * HZ / 1000;
>> + chip->vendor.timeout_c = TIS_SHORT_TIMEOUT * HZ / 1000;
>> + chip->vendor.timeout_d = TIS_SHORT_TIMEOUT * HZ / 1000;
>
> Shouldn't these use msec_to_jiffies?

Indeed * HZ / 1000 can be one jiffy less than msec_to_jiffies(),
depending on HZ. I'll change it.

--Ed

\
 
 \ /
  Last update: 2016-06-08 23:21    [W:9.293 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site