lkml.org 
[lkml]   [2016]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] sched/debug: fix deadlock when enabling sched events
On Tue, Jun 07, 2016 at 09:54:48PM +0200, Peter Zijlstra wrote:
> On Tue, Jun 07, 2016 at 02:43:17PM -0500, Josh Poimboeuf wrote:
> > 1. Instead of just warning and allowing the tracepoints to be broken,
> > I'd argue that it would be better to make them work by forcing
> > schedstats enabled and printing a warning about that, which is what's
>
> Forcing them enabled doesn't make them useful per se; some of these
> tracepoint rely on previously recoded state, which now wasn't previously
> recorded because back then it was disabled.

Ah, that's true. Though this issue exists regardless of whether we
force enable schedstats or the user manually enables them. It's a side
effect of allowing schedstats to be enabled after booting.

--
Josh

\
 
 \ /
  Last update: 2016-06-07 23:21    [W:0.235 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site