lkml.org 
[lkml]   [2016]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] Proper ro_after_init implementation on s390
On Tue, Jun 07, 2016 at 08:49:14AM -0700, Kees Cook wrote:
> > Heiko Carstens (2):
> > vmlinux.lds.h: allow arch specific handling of ro_after_init data section
> > s390/mm: add proper __ro_after_init support
> >
> > arch/s390/include/asm/cache.h | 3 ---
> > arch/s390/include/asm/sections.h | 1 +
> > arch/s390/kernel/vmlinux.lds.S | 12 +++++++++++-
> > arch/s390/mm/init.c | 7 ++++---
> > arch/s390/mm/vmem.c | 7 +++----
> > include/asm-generic/vmlinux.lds.h | 10 +++++++++-
> > 6 files changed, 28 insertions(+), 12 deletions(-)
>
> Awesome! This looks great to me! Have you had a chance to look through
> any of the arch/s390/ __init code for variables that should be marked
> __ro_after_init?

Not yet, and actually this I'm a bit reluctant to do that, since any wrong
annotation will lead to kernel crashes sooner or later ;)
However I'll look into this as well.

> Reviewed-by: Kees Cook <keescook@chromium.org>

Thanks! I add that to both patches.

(sorry for the broken threading; one of the outgoing mail servers rewrote
all Message-Id headers)

\
 
 \ /
  Last update: 2016-06-07 20:21    [W:0.092 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site