lkml.org 
[lkml]   [2016]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] sched/debug: fix /proc/sched_debug regression
On Tue, Jun 07, 2016 at 02:47:57PM +0100, Mel Gorman wrote:
> On Fri, Jun 03, 2016 at 05:58:40PM -0500, Josh Poimboeuf wrote:
> > Commit cb2517653fcc ("sched/debug: Make schedstats a runtime tunable
> > that is disabled by default") introduced a bug when CONFIG_SCHEDSTATS is
> > enabled and the runtime tunable is disabled (which is the default). The
> > wait-time, sum-exec, and sum-sleep fields are missing from the
> > /proc/sched_debug file in the runnable_tasks section.
> >
>
> I take it that this breaks userspace parsing?

In theory, yes, though I don't know if there are any tools out there
which parse it.

> > Fix it with a new schedstat_val() macro which returns the field value
> > when schedstats is enabled and zero otherwise. The macro works with
> > both SCHEDSTATS and !SCHEDSTATS. I put the macro in stats.h since it
> > might end up being useful in other places.
> >
> > Fixes: cb2517653fcc ("sched/debug: Make schedstats a runtime tunable that is disabled by default")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> Acked-by: Mel Gorman <mgorman@techsingularity.net>

Thanks!

--
Josh

\
 
 \ /
  Last update: 2016-06-07 20:21    [W:0.055 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site