Messages in this thread | | | Date | Tue, 7 Jun 2016 12:06:18 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 1/9] pinctrl: as3722: make it explicitly non-modular |
| |
On Tuesday 07 June 2016 08:13 AM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config PINCTRL_AS3722 > bool "Pinctrl and GPIO driver for ams AS3722 PMIC" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_ALIAS and MODULE_DEVICE_TABLE are a no-op for > non-modular code and hence both are removed. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Laxman Dewangan <ldewangan@nvidia.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >
I will say lets make the driver as tristate.
tristate "Pinctrl and GPIO driver for ams AS3722 PMIC"
| |