Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH] loop: Make user notify for adding loop device failed | Date | Tue, 07 Jun 2016 09:42:56 -0400 |
| |
Minfei Huang <mnghuan@gmail.com> writes:
> There is no error number returned if loop driver fails in function > alloc_disk to add new loop device. Add a correct error number to make > user notify in this case. > > Signed-off-by: Minfei Huang <mnghuan@gmail.com> > --- > drivers/block/loop.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 1fa8cc2..2caaf6f 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -1765,6 +1765,7 @@ static int loop_add(struct loop_device **l, int i) > */ > queue_flag_set_unlocked(QUEUE_FLAG_NOMERGES, lo->lo_queue); > > + err = -ENOMEM; > disk = lo->lo_disk = alloc_disk(1 << part_shift); > if (!disk) > goto out_free_queue;
Looks good.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
| |