Messages in this thread | | | From | Pramod Kumar <> | Date | Tue, 7 Jun 2016 17:27:29 +0530 | Subject | RE: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer |
| |
Hi Florian,
> -----Original Message----- > From: Florian Fainelli [mailto:f.fainelli@gmail.com] > Sent: 07 June 2016 00:06 > To: Pramod Kumar; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; > Kumar Gala; Catalin Marinas; Will Deacon; Kishon Vijay Abraham I; David S. > Miller > Cc: devicetree@vger.kernel.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; bcm-kernel-feedback-list@broadcom.com; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for > Broadcom MDIO bus multiplexer > > On 06/06/2016 05:41 AM, Pramod Kumar wrote: > > Add DT binding doc for Broadcom MDIO bus multiplexer driver. > > > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > > > > +for example: > > + mdio_mux_iproc: mdio-mux@6602023c { > > I think Rob wanted you to drop the underscores here in favor of dashes, > there > are more below, not critical imho. >
I'd changed node name in favor of dashes. I don't think Label could be written with hyphens,"-". "-" in label provides DT parsing error.
> > + compatible = "brcm,mdio-mux-iproc"; > > + reg = <0x6602023c 0x14>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + mdio@0 { > > + reg = <0x0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pci_phy0: pci-phy@0 { > > > -- > Florian
Regards, Pramod
| |