Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH] drm/vc4: clean up error exit path on failed dpi_connector allocation | Date | Mon, 06 Jun 2016 14:29:26 -0700 |
| |
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com> > > There is redundant code in the clean up exit path when dpi_connector > fails to be allocated. The current code checks if connector is NULL > before destroying it, in fact, connector is NULL at this point so > the check is redundant and can be removed. The final clean up is > that we can remove the goto fail with a simple return and the unused > variable ret. > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed and pulled to drm-vc4-next. Thanks! [unhandled content-type:application/pgp-signature] | |