lkml.org 
[lkml]   [2016]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] sd: remove redundant check for BLK_DEF_MAX_SECTORS
    From
    Date
    >>>>> "Long" == Long Li <longli@microsoft.com> writes:

    Long,

    Long> The reason is that, max_sectors already has value at this point,
    Long> the default value is SCSI_DEFAULT_MAX_SECTORS
    Long> (include/scsi/scsi_host.h). The lower layer host driver can change
    Long> this value in its template.

    The LLD sets max_hw_sectors which indicates the capabilities of the
    controller DMA hardware. Whereas the max_sectors limit is set by sd to
    either follow advise by the device or--if not provided--use the block
    layer default. max_sectors governs the size of READ/WRITE requests and
    do not reflect the capabilities of the DMA hardware.

    Long> I think the drivers care about this value have already set it. So
    Long> it's better not to change it again. If they want max_sectors to be
    Long> set by sd, they can use BLOCK LIMITS VPD to tell it to do so.

    Most drivers don't have the luxury of being able to generate VPDs for
    their attached target devices :)

    --
    Martin K. Petersen Oracle Linux Engineering

    \
     
     \ /
      Last update: 2016-06-07 06:01    [W:2.613 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site