lkml.org 
[lkml]   [2016]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/9] pinctrl: zynq: make it explicitly non-modular
    Date
    The Kconfig currently controlling compilation of this code is:

    config PINCTRL_ZYNQ
    bool "Pinctrl driver for Xilinx Zynq"

    ...meaning that it currently is not being built as a module by anyone.

    Lets remove the modular code that is essentially orphaned, so that
    when reading the driver there is no doubt it is builtin-only.

    Since module_platform_driver() uses the same init level priority as
    builtin_platform_driver() the init ordering remains unchanged with
    this commit.

    Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

    We also delete the MODULE_LICENSE tag etc. since all that information
    is already contained at the top of the file in the comments.

    Cc: Linus Walleij <linus.walleij@linaro.org>
    Cc: Michal Simek <michal.simek@xilinx.com>
    Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
    Cc: linux-gpio@vger.kernel.org
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/pinctrl/pinctrl-zynq.c | 13 +------------
    1 file changed, 1 insertion(+), 12 deletions(-)

    diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
    index 8fdc60c5aeaf..7afdbede6823 100644
    --- a/drivers/pinctrl/pinctrl-zynq.c
    +++ b/drivers/pinctrl/pinctrl-zynq.c
    @@ -20,7 +20,7 @@
    */
    #include <linux/io.h>
    #include <linux/mfd/syscon.h>
    -#include <linux/module.h>
    +#include <linux/init.h>
    #include <linux/of.h>
    #include <linux/platform_device.h>
    #include <linux/pinctrl/pinctrl.h>
    @@ -1210,7 +1210,6 @@ static const struct of_device_id zynq_pinctrl_of_match[] = {
    { .compatible = "xlnx,pinctrl-zynq" },
    { }
    };
    -MODULE_DEVICE_TABLE(of, zynq_pinctrl_of_match);

    static struct platform_driver zynq_pinctrl_driver = {
    .driver = {
    @@ -1225,13 +1224,3 @@ static int __init zynq_pinctrl_init(void)
    return platform_driver_register(&zynq_pinctrl_driver);
    }
    arch_initcall(zynq_pinctrl_init);
    -
    -static void __exit zynq_pinctrl_exit(void)
    -{
    - platform_driver_unregister(&zynq_pinctrl_driver);
    -}
    -module_exit(zynq_pinctrl_exit);
    -
    -MODULE_AUTHOR("Sören Brinkmann <soren.brinkmann@xilinx.com>");
    -MODULE_DESCRIPTION("Xilinx Zynq pinctrl driver");
    -MODULE_LICENSE("GPL");
    --
    2.8.0
    \
     
     \ /
      Last update: 2016-06-07 05:01    [W:4.295 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site