lkml.org 
[lkml]   [2016]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 05/12] lockdep: Implement crossrelease feature
On Thu, Jun 30, 2016 at 03:03:57PM +0200, Peter Zijlstra wrote:
> On Mon, Jun 20, 2016 at 01:55:20PM +0900, Byungchul Park wrote:
> > +struct cross_lock {
> > + unsigned int gen_id;
>
> 4 byte hole
>
> > + struct list_head xlock_entry;
> > +
> > + /*
> > + * Seperated hlock instance. This will be used when
> > + * building a dependency chain for a crosslock, say,
> > + * commit.
> > + */
> > + struct held_lock hlock;
> > +
> > + int ref; /* reference count */
>
> 4 byte hole
>
> > +};
>
> A trivial re-arrangement would shrink this structure by 8 bytes.

Ok. Thank you.

>
> After which its still at least 64 bytes.

I will try to reduce the size as much as possible. However I think it's
not serious problem beacuse this is just a debug feature.

Thanks,
Byungchul

\
 
 \ /
  Last update: 2016-07-01 02:01    [W:0.464 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site