Messages in this thread | | | Subject | Re: [PATCH 04/15] lirc_dev: replace printk with pr_* or dev_* | From | Joe Perches <> | Date | Wed, 29 Jun 2016 17:27:26 -0700 |
| |
On Wed, 2016-06-29 at 22:20 +0900, Andi Shyti wrote: > This patch mutes also all the checkpatch warnings related to > printk. > > Reword all the printouts so that the string doesn't need to be > split, which fixes the following checkpatch warning:
Adding
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include would allow these to be prefixed automatically and allow the embedded prefixes to be removed. > diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c [] > @@ -240,59 +240,51 @@ static int lirc_allocate_driver(struct lirc_driver *d) > int err; > > if (!d) { > - printk(KERN_ERR "lirc_dev: lirc_register_driver: " > - "driver pointer must be not NULL!\n"); > + pr_err("lirc_dev: driver pointer must be not NULL!\n"); > err = -EBADRQC; > goto out; > }
pr_err("driver pointer must not be NULL!\n");
And typical multiple line statement alignment is to the open parenthesis.
| |