Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Wed, 29 Jun 2016 15:16:11 +0200 | Subject | Re: [PATCH V2 4/4] ACPI,PCI,IRQ: correct operator precedence |
| |
On Wed, Jun 29, 2016 at 10:27 AM, Sinan Kaya <okaya@codeaurora.org> wrote: > The omitted parenthesis prevents the addition operation when > acpi_penalize_isa_irq function is called. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Well, this is a rather obvious one, so I'm wondering why it is the last one in the series?
> --- > drivers/acpi/pci_link.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c > index 8c08971..c983bf7 100644 > --- a/drivers/acpi/pci_link.c > +++ b/drivers/acpi/pci_link.c > @@ -872,7 +872,7 @@ void acpi_penalize_isa_irq(int irq, int active) > { > if ((irq >= 0) && (irq < ARRAY_SIZE(acpi_isa_irq_penalty))) > acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) + > - active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING; > + (active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING); > } > > bool acpi_isa_irq_available(int irq) > --
Thanks, Rafael
| |