Messages in this thread | | | From | Manish Badarkhe <> | Date | Wed, 29 Jun 2016 16:15:22 +0530 | Subject | Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs |
| |
Hi Keerthy,
sorry ignore my last two comments in previous mail.
On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe <badarkhe.manish@gmail.com> wrote: > Hi Keerthy > > Some minor comment > >> +static int lp873x_gpio_direction_output(struct gpio_chip *chip, >> + unsigned int offset, int value) >> +{ >> + struct lp873x_gpio *gpio = gpiochip_get_data(chip); >> + >> + /* Set the initial value */ >> + regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL, >> + BIT(offset * 4), value ? BIT(offset * 4) : 0); >> + >> + return 0; >> +}
Error needs to be return, this function always return 0.
Regards Manish Badarkhe
| |