Messages in this thread | | | From | Bhaktipriya Shridhar <> | Date | Tue, 28 Jun 2016 22:17:20 +0530 | Subject | Re: [PATCH v2] xen: xenbus: Remove create_workqueue |
| |
Ping! Thanks, Bhaktipriya
On Tue, May 31, 2016 at 10:59 PM, Tejun Heo <tj@kernel.org> wrote: > On Tue, May 31, 2016 at 10:26:30PM +0530, Bhaktipriya Shridhar wrote: >> System workqueues have been able to handle high level of concurrency >> for a long time now and there's no reason to use dedicated workqueues >> just to gain concurrency. Replace dedicated xenbus_frontend_wq with the >> use of system_wq. >> >> Unlike a dedicated per-cpu workqueue created with create_workqueue(), >> system_wq allows multiple work items to overlap executions even on >> the same CPU; however, a per-cpu workqueue doesn't have any CPU >> locality or global ordering guarantees unless the target CPU is >> explicitly specified and the increase of local concurrency shouldn't >> make any difference. >> >> In this case, there is only a single work item, increase of concurrency >> level by switching to system_wq should not make any difference. >> >> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> > > Acked-by: Tejun Heo <tj@kernel.org> > > Thanks. > > -- > tejun
| |