Messages in this thread | | | Subject | Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ? | From | Benjamin Herrenschmidt <> | Date | Tue, 28 Jun 2016 19:35:10 +1000 |
| |
On Tue, 2016-06-28 at 08:06 +0100, David Binderman wrote: > > I don't know the code, but given that insn is unsigned long and so > can go > past 32 bits, using a cast to unsigned int might throw away the > possibly important > upper bits.
our instructions are only ever 32-bits. That xmon code is ancient and originated from 32-bits stuff. In fact some of Paulus earliest xmons might even have run on platforms where int is 16 bits :-)
Cheers, Ben.
| |