Messages in this thread | | | Subject | Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64 | From | Krzysztof Kozlowski <> | Date | Tue, 28 Jun 2016 10:49:12 +0200 |
| |
On 06/28/2016 10:41 AM, Herbert Xu wrote: > On Tue, Jun 28, 2016 at 09:23:07AM +0200, Krzysztof Kozlowski wrote: >> gcc 4.7.3 for ARM on Ubuntu couldn't link tcrypt module because of >> division of s64: >> ERROR: "__aeabi_ldivmod" [crypto/tcrypt.ko] undefined! >> >> Fixes: 087bcd225c56 ("crypto: tcrypt - Add speed tests for SHA multibuffer algorithms") >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > I'd prefer to be consistent here and just use unsigned long like > every other speed test in tcrypt. This code has some serious > issues, such as not waiting for completion in case of an error. > > Let me try to fix them up. > > Thanks! > > ---8<--- > Subject: crypto: tcrypt - Use unsigned long for mb ahash cycle counter > > For the timescales we are working against there is no need to > go beyond unsigned long. > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> >
Works fine for me:
Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards, Krzysztof
| |