lkml.org 
[lkml]   [2016]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.
    Date
    Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young:
    > On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote:
    > > Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young:
    > > What is bad about the description of top_down?
    > It is not clear enough to me, I personally think the original one in
    > source code is better:
    > /* allocate from top of memory hole */

    Actually I realized there's some discrepancy in how the x86 code uses
    top_down and how I need it to work in powerpc. This may be what is confusing
    about my comment and the existing comment.

    x86 always walks memory from bottom to top but if top_down is true, in each
    memory region it will allocate the memory hole in the highest address within
    that region. I don't know why it is done that way, though.

    On powerpc, the memory walk itself should be from top to bottom, as well as
    the memory hole allocation within each memory region.

    Should I add a separate top_down argument to kexec_locate_mem_hole to
    control if the memory walk should be from top to bottom, and then the
    bottom_up member of struct kexec_buf controls where inside each memory
    region the memory hole will be allocated?

    --
    []'s
    Thiago Jung Bauermann
    IBM Linux Technology Center

    \
     
     \ /
      Last update: 2016-06-27 19:21    [W:4.055 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site