lkml.org 
[lkml]   [2016]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] dsa: mv88e6xxx: hide unused functions
From
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Thu, 23 Jun 2016 11:21:27 -0400

> Hi,
>
> Arnd Bergmann <arnd@arndb.de> writes:
>
>> When CONFIG_NET_DSA_HWMON is disabled, we get warnings about two unused
>> functions whose only callers are all inside of an #ifdef:
>>
>> drivers/net/dsa/mv88e6xxx.c:3257:12: 'mv88e6xxx_mdio_page_write' defined but not used [-Werror=unused-function]
>> drivers/net/dsa/mv88e6xxx.c:3244:12: 'mv88e6xxx_mdio_page_read' defined but not used [-Werror=unused-function]
>>
>> This adds another ifdef around the function definitions. The warnings
>> appeared after the functions were marked 'static', but the problem
>> was already there before that.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 57d3231057e9 ("net: dsa: mv88e6xxx: fix style issues")
>
> Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> David, this patch is meant for net-next. It applies cleanly *before* my
> last two submissions:
>
> 1/2 http://patchwork.ozlabs.org/patch/638773/
> 2/2 http://patchwork.ozlabs.org/patch/638772/

Oops, I applied those already.

Arnd, please respin if necessary.

\
 
 \ /
  Last update: 2016-06-27 17:21    [W:0.050 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site