lkml.org 
[lkml]   [2016]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/7] efi: Convert efi_call_virt to efi_call_virt_pointer
On Mon, Jun 27, 2016 at 01:00:50PM +0200, Ingo Molnar wrote:
>
> * Matt Fleming <matt@codeblueprint.co.uk> wrote:
>
> > +#define efi_call_virt_pointer(p, f, args...) \
> > +({ \
> > + efi_status_t __s; \
> > + unsigned long flags; \
> > + \
> > + arch_efi_call_virt_setup(); \
> > + \
> > + local_save_flags(flags); \
> > + __s = arch_efi_call_virt(p, f, args); \
> > + efi_call_virt_check_flags(flags, __stringify(f)); \
> > + \
> > + arch_efi_call_virt_teardown(); \
> > + \
> > + __s; \
> > +})
> > +
> > +#define __efi_call_virt_pointer(p, f, args...) \
> > +({ \
> > + unsigned long flags; \
> > + \
> > + arch_efi_call_virt_setup(); \
> > + \
> > + local_save_flags(flags); \
> > + arch_efi_call_virt(p, f, args); \
> > + efi_call_virt_check_flags(flags, __stringify(f)); \
> > + \
> > + arch_efi_call_virt_teardown(); \
> > +})
>
> Note that while at it I renamed 'flags' to '__flags' because 'flags' is
> a commonly used variable name and the 'efi_status_t __s' variable was
> macro-prefixed already.
>
> Any objections?

FWIW, none from me. I probably should have done that when I wrote the
original {__,}efi_call_virt macros.

Thanks,
Mark.

\
 
 \ /
  Last update: 2016-06-27 14:01    [W:0.155 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site