Messages in this thread | | | Date | Sat, 25 Jun 2016 14:22:37 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] printk: introduce should_ignore_loglevel() |
| |
On (06/24/16 18:05), Petr Mladek wrote: [..] > > +static bool should_ignore_loglevel(int level) > > +{ > > + return (level >= console_loglevel && !ignore_loglevel); > > The patch looks fine. It is nice optimization. > > I was just quite confused by the name of this function. A function > called should_ignore_loglevel() should not return false when > ignore_loglevel variable is true. > > I would call it ignore_message() or ignore_message_on_console() or so.
Hello Petr, you are right.
I was thinking about
s/should_ignore_loglevel/suppress_message/g or.... s/should_ignore_loglevel/suppress_message_by_level/g s/should_ignore_loglevel/suppress_message_printing/g
suppress_message_printing() is probably fine.
will it work for you guys?
-ss
| |