lkml.org 
[lkml]   [2016]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout
    Date
    From: Peter Jones <pjones@redhat.com>

    Add a comment documenting why EFI GUIDs are laid out like they are.
    Ideally I'd like to change all the ", " to "," too, but right now the
    format is such that checkpatch won't complain with new ones, and staring
    at checkpatch didn't get me anywhere towards making that work.

    Signed-off-by: Peter Jones <pjones@redhat.com>
    Cc: Joe Perches <joe@perches.com>
    Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
    ---
    include/linux/efi.h | 17 ++++++++++++++++-
    1 file changed, 16 insertions(+), 1 deletion(-)

    diff --git a/include/linux/efi.h b/include/linux/efi.h
    index f196dd0b0f2f..03009695760d 100644
    --- a/include/linux/efi.h
    +++ b/include/linux/efi.h
    @@ -536,7 +536,22 @@ typedef efi_status_t efi_query_variable_store_t(u32 attributes,
    void efi_native_runtime_setup(void);

    /*
    - * EFI Configuration Table and GUID definitions
    + * EFI Configuration Table and GUID definitions
    + *
    + * These should be formatted roughly like the ones in the UEFI SPEC has
    + * them. It makes them easier to grep for, and they look the same when
    + * you're staring at them. Here's the guide:
    + *
    + * GUID: 12345678-1234-1234-1234-123456789012
    + * Spec:
    + * #define EFI_SOME_PROTOCOL_GUID \
    + * {0x12345678,0x1234,0x1234,\
    + * {0x12,0x34,0x12,0x34,0x56,0x78,0x90,0x12}}
    + * Here:
    + * #define SOME_PROTOCOL_GUID \
    + * EFI_GUID(0x12345678, 0x1234, 0x1234, \
    + * 0x12, 0x34, 0x12, 0x34, 0x56, 0x78, 0x90, 0x12)
    + * ^ tab ^tab ^ space
    */
    #define NULL_GUID \
    EFI_GUID(0x00000000, 0x0000, 0x0000, \
    --
    2.7.3
    \
     
     \ /
      Last update: 2016-06-25 10:01    [W:6.413 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site