Messages in this thread | | | Date | Fri, 24 Jun 2016 12:27:27 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations |
| |
On Tue, Jun 21, 2016 at 06:10:28PM -0700, Ed Swierk wrote:
> if (chip->ops->req_canceled(chip, status)) { > dev_err(chip->pdev, "Operation Canceled\n"); > + dev_dbg(chip->pdev, "canceled command %d after %d ms\n", > + ordinal, jiffies_to_msecs(jiffies - > start));
[..]
> chip->ops->cancel(chip); > dev_err(chip->pdev, "Operation Timed out\n"); > + dev_dbg(chip->pdev, "command %d timed out after %d ms\n", ordinal, > + jiffies_to_msecs(jiffies - start));
No sense in logging twice, just enhance the existingerror message.
Jason
| |